-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPS-5046 support spark 3.4.0 on SPOK #98
Conversation
dc25d08
to
8abe6fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are broken, it seems because the Dockerfile
is not properly set up to install jdk8. this needs to be fixed. I recommend testing locally using make test
, or for faster iteration, make dev
then run tests with tox
when you're inside the container.
8abe6fc
to
f1dd33a
Compare
Looks good, but let's make sure! We can add a |
9db2d1d
to
411d5af
Compare
411d5af
to
d186b08
Compare
Looks like there are several failures with
it would seem that more work is required here to make everything work. |
aeec316
to
a6a47bf
Compare
a6a47bf
to
f5a8595
Compare
spark 3.4.0 made a change to spark type
CharType
which requires the constructor to take a parameterlength
so we are using spark's internal method to take care of all that parsing