Skip to content

Commit

Permalink
Fix deb packaging for ARM v6/v7
Browse files Browse the repository at this point in the history
Relates to goreleaser/goreleaser#2721

There's a filename clash because some platforms consider armhf to be ARMv6 and some consider it to be ARMv7.
Fallback to build and package only ARMv6 because ARMv6 binaries are going to work on ARMv7 anyway.

Note: If we really have to release ARMv7 for other platforms, we can split the builds and packaging and then filter the builds used for packaging but that require extra work/maintenance so we will implement it only if required.
  • Loading branch information
tucksaun committed Feb 24, 2023
1 parent d50c07a commit 0b67071
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
8 changes: 6 additions & 2 deletions .goreleaser.yml
Expand Up @@ -23,8 +23,11 @@ builds:
- arm
- arm64
goarm:
# Because of a limitation in DEB packaging we can only build and package
# a single ARMv6 or v7 variant at a single time. As ARMv6 is upwards
# compatible with ARMv7 so let's only build ARMv6 here (default value
# anyway)
- 6
- 7
ignore:
- goos: windows
goarch: arm
Expand Down Expand Up @@ -155,7 +158,8 @@ dockers:
- "--label=org.opencontainers.image.version={{.Version}}"
- image_templates: [ "ghcr.io/symfony-cli/{{ .ProjectName }}:{{ .Version }}-arm32v7" ]
goarch: arm
goarm: '7'
# ARMv6 is upwards compatible with ARMv7
goarm: '6'
use: buildx
build_flag_templates:
- "--pull"
Expand Down
3 changes: 2 additions & 1 deletion installer/bash-installer
Expand Up @@ -129,7 +129,8 @@ case ${machine} in
machine="armv6"
;;
armv7*)
machine="armv7"
# ARMv6 is upwards compatible with ARMv7
machine="armv6"
;;
aarch64*|armv8*|arm64)
machine="arm64"
Expand Down

0 comments on commit 0b67071

Please sign in to comment.