-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor inputdata #14
Conversation
…itespace character was put into the "temp" variable
…us runs affects the running of tests
Big refactor of input data processing, still work in progress
Unit Test Results (x64-linux) 1 files ± 0 1 suites ±0 1s ⏱️ -1s Results for commit 46db414. ± Comparison against base commit e1e0547. This pull request removes 1 and adds 58 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Unit Test Results (x64-osx) 1 files ± 0 1 suites ±0 3s ⏱️ ±0s Results for commit 46db414. ± Comparison against base commit e1e0547. This pull request removes 1 and adds 58 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Unit Test Results (x64-windows) 1 files ± 0 1 suites ±0 1s ⏱️ ±0s Results for commit 46db414. ± Comparison against base commit e1e0547. This pull request removes 1 and adds 58 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
…llutes the namespace of all other files including them
This reverts commit f63ec65.
…functionality is now handled upon parsing the input file
…abet mapping of another inputdata
…s added by read_json aren't predicted on as well
Ok, predict seems to work now. I added a little convenience method to copy the alphabet mapping from the inputdata that gets loaded from the apta json, so we can easily create a new inputdata for the traces we want to predict that has the same mapping. |
…e traces were read and predicted one by one to save on memory
This PR refactors the code that parses the input files for flexfringe.
There are now separate classes for parsing csv and abbadingo formatted files, and their code has been made more independent of each other. This should fix the issue where certain csv files could not be parsed correctly because they contained characters that were used as delimiters in the abbadingo file format.
There are still some things to do before this can be merged, as streaming mode is currently broken and I am not sure what the best way to fix it is. Discussions with @RobBa underway :)