Write compile spec as JSON #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cool thing about Jackson is that it doesn't need any annotations.
Another cool thing about Jackson is that we don't need to annotate the properties to use the custom serializer.
This will cause all tests for the contents of the archive to fail, because it will contain an extra entry. It doesn't make sense to fix these fails, as we anyway want to remove the compile spec in XML format in a future step.
This works for SV-related properties, but mysteriously fails for C sources. Once both return the same object, we will be able to stop using the XML version in favor of the JSON version.
The wonky name of the getter, with the double capital letter, confuses Jackson, causing it to think that the property is called `csourceFiles` (not the lowercase "s"). It needs the annotation both for the getter, which is used for serialization, and for the field, which is (probably) used for deserialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.