Standardize on PyTorch for machine learning models #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2022
MatthijsBurgh
requested changes
Feb 6, 2022
| @@ -0,0 +1,2 @@ | |||
| #!/bin/bash | |||
| nosetests -vv "$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" | |||
There was a problem hiding this comment.
Why is this needed? Just for manual testing? As we use the catkin macro.
|
Also we should include |
MatthijsBurgh
requested changes
Feb 26, 2022
There was a problem hiding this comment.
Fix catkin lint
image_recognition_pytorch: package.xml: error: unknown package 'python3-onnxruntime-pip'
image_recognition_pytorch: package.xml: error: unknown package 'python3-pytorch-pip'
image_recognition_pytorch: warning: file 'scripts/download_model' is executable but not installed
image_recognition_pytorch: package.xml: notice: meaningless package description 'The image_recognition_pytorch package'
catkin_lint: checked 1 packages and found 4 problems
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Age & Gender recognition
TODO
image_recognition_kerasinrobot_launch_files? Switch to use the pytorch version of face_properties robot_launch_files#70CI restriction