New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version check of Urwid #82

Open

Freso wants to merge 1 commit into tuffy:master from Freso:fix-urwid-version

Freso commented Mar 27, 2024

Urwid used to provide VERSION both in its main namespace (urwid.VERSION) and under version (urwid.version.VERSION), but as of commit 8d8e4b678cc0f93149a4a964b26ee11fb136ea0f this is now only available in the main namespace, as setuptools-scm does not include VERSION in its generated version.py. This breaks audiotools with urwid>=2.2.0 (2023-09-21).

The simple fix is to just look at urwid.VERSION instead of urwid.version.VERSION, which is what this patch does.


          Fix version check of Urwid

Urwid used to provide `VERSION` both in its main namespace
(`urwid.VERSION`) and under `version` (`urwid.version.VERSION`), but
as of commit 8d8e4b678cc0f93149a4a964b26ee11fb136ea0f[1] this is now
only available in the main namespace[2], as setuptools-scm does not
include `VERSION` in its generated `version.py`[3]. This breaks
audiotools with urwid>=2.2.0 (2023-09-21).

The simple fix is to just look at `urwid.VERSION` instead of
`urwid.version.VERSION`, which is what this patch does.

[1] urwid/urwid@8d8e4b6
[2] urwid/urwid@8d8e4b6#diff-622c6cdaa0aebea827e82ba7a1e6127f21fe51c58ff6a88ff6b018c3885ea2e9L105-R217
[3] https://github.com/pypa/setuptools_scm/blob/main/src/setuptools_scm/_integration/dump_version.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment