feat(terminal)!: add inline viewport #114
Conversation
|
I just checked out the example, seems either bugged / unfinished or I'm just not understanding what @fdehau was trying to do. On my machine the example either wrote on top of itself on my occasions, or failed to "coexist" with previous outputs in my terminal. I'll try and take a look at this PR when I have the time, but I'll be pretty busy these upcoming days. |
my fault, push incoming |
|
Looks awesome now 😄 |
conradludgate
changed the title
|
Hey! I don't want to pressure or anything, but the next Atuin release is blocked on this one getting in. Is there anything I can do to help? Also - so good to see TUI getting maintained again, nice work! 🙏 |
Once ratatui-org/ratatui#114 has been merged, we can undo this! But otherwise we can't publish to crates.io with a git dependency.
Once ratatui-org/ratatui#114 has been merged, we can undo this! But otherwise we can't publish to crates.io with a git dependency.
* Vendor ratatui temporarily Once ratatui-org/ratatui#114 has been merged, we can undo this! But otherwise we can't publish to crates.io with a git dependency. * make tests pass * Shush. * these literally just fail in nix, nowhere else idk how to work with nix properly, and they're also not our tests
orhun
changed the title
|
I was struggling with inline rendering, and had almost given up when I found this! Great work! Does anyone know when this might be included in a release? Pointing the dependency to this commit works locally, but I'd love to use this in a crates.io package as well. |
|
Thanks @hermannm! I'm currently having a chat with the other maintainers about the next possible release. We certainly don't want to keep people waiting 🐻 |
originally taken from fdehau/tui-rs#552.
Updates
Viewporttype, making it an enum withFullscreen,InlineandFixedviews.Inline(_)includes the height of the inline screen.Adds an
insert_beforemethod that can write permanent lines above the inline tui. Intended usecase is likeyarn install, where there would be multiple updating elements at the bottom of the screen, and then 'xxx installed' would be permanent logs above the updating elements.I've tried to minimise the breaking changes from the original PR, but there's still a breaking change in the
Backendtrait. In theory I can add some default methods to make it not a breaking change(CC @pdecat, atuinsh/atuin#648)