Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crossterm to 0.26 with CI fix #43

Closed
wants to merge 4 commits into from
Closed

Conversation

orhun
Copy link
Sponsor Member

@orhun orhun commented Feb 12, 2023

Upstream: #689

Description

Testing guidelines

I checked all examples by cargo run --example {example-name} and confirmed they work on iTerm2 on my Mac machine.

Checklist

  • I have read the contributing guidelines.
  • I have added relevant tests. (Since this PR just upgrading existing dependency, no tests need to be added)
  • I have documented all new additions.

Description

crossterm v0.26.0 was released recently. And some people are starting to use the latest version. Since this crate requires crossterm 0.25, both 0.25 and 0.26 are mixed in user's project when the user depends on crossterm directly. I actually saw an issue around this in my tui-textarea project: rhysd/tui-textarea#9

The best way to solve the issue is to follow the latest crossterm version by tui crate. I checked the release note and tui crate. Breaking changes seem not relevant to tui crate.

This is a breaking change due to MSRV bump from 1.56 to 1.58. crossterm 0.26 is using inline format arguments feature and it requires 1.58.

@orhun
Copy link
Sponsor Member Author

orhun commented Feb 12, 2023

rhysd said: I fixed CI as well:

  • Fix installing cargo-make requires higher Rust version
  • Fix all clippy warnings with the latest stable toolchain

@orhun
Copy link
Sponsor Member Author

orhun commented Feb 12, 2023

rhysd said: I think the Actions settings for this repository also need to be updated. The Linux (1.56.1) and Windows (1.56.1) workflows are required to be passed, but they don't exist.

@orhun
Copy link
Sponsor Member Author

orhun commented Feb 12, 2023

rhysd said: Rust 1.67.1 cancelled enabling uninlined_format_args lint rule which was once enabled by default at 1.67.0. So I created a commit to fix clippy warnings again at 06fba01.

@mindoodoo mindoodoo added the Build Build system related. label Feb 14, 2023
@sayanarijit
Copy link
Member

Closing wrt #51

@joshka joshka deleted the 689/crossterm-0.26 branch July 4, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Build system related.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants