[#596][#597] Fix decodeIntIfPresent
and related tests
#598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #596 and #597
Short description π
Some of our Xcode projects were failing to be decoded due to
proxyType
being encoded as an Int whendecodeIntIfPresent
only tries to decode as String/Bool.Solution π¦
decodeIntIfPresent
to try to decodeUInt
if decoding as String/Bool fails._____BuildPhaseTests
to properly check failure cases now thatdecodeIntIfPresent
doesn't wrongly throw when trying to decode encoded ints.Implementation π©βπ»π¨βπ»