Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning when targeting macOS 13 #814

Merged
merged 1 commit into from Mar 8, 2024
Merged

Fix deprecation warning when targeting macOS 13 #814

merged 1 commit into from Mar 8, 2024

Conversation

jszumski
Copy link
Contributor

@jszumski jszumski commented Mar 6, 2024

Another attempt at #710

Short description 📝

Fixes this deprecation warning when targeting macOS 13:

Sources/XcodeProj/Extensions/String+md5.swift:63:16: warning: 'init(bytesNoCopy:length:encoding:freeWhenDone:)' was deprecated in macOS 13: String does not support no-copy initialization
        return String(bytesNoCopy: ptr, length: hexLen, encoding: .utf8, freeWhenDone: true)!

Solution 📦

I cherry-picked an updated version from swift-crypto

Implementation 👩‍💻👨‍💻

  • Applied cherry pick
  • swift test

kwridan
kwridan approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you for addressing this @jszumski

@kwridan kwridan merged commit 313aaf1 into tuist:main Mar 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

@kwridan kwridan kwridan approved these changes

@luispadron luispadron luispadron approved these changes

@danieleformichelli danieleformichelli Awaiting requested review from danieleformichelli

@fortmarek fortmarek Awaiting requested review from fortmarek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jszumski @brentleyjones @kwridan @luispadron