You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When creating a project with a target without any build phases (TargetActions), two empty build phases are added, unnecessarily: Embed Precompiled Frameworks (runScript) and Embed Frameworks (copyFiles).
To Reproduce
Create a Target without specifying any TargetActions
Add this Target as part of the declared Project.
Check that two empty build phases are added: Embed Precompiled Frameworks (runScript) and Embed Frameworks (copyFiles).
Expected behavior
If there are no precompiled or embedded frameworks, do not generate these empty build phases.
Screenshots
When comparing the diff with an existing project via xcdiff, the following is shown:
Having them there as empty build phases shouldn't be harmful. If you're interested in tackling this - the class responsible for adding those particular build phases is LinkGenerator
The thing that is worth checking is if any of the acceptance tests validate those empty build phases, they would potentially need to updated to perform a different check if we remove those phases completely.
Describe the bug
When creating a project with a target without any build phases (
TargetActions
), two empty build phases are added, unnecessarily: Embed Precompiled Frameworks (runScript) and Embed Frameworks (copyFiles).To Reproduce
Target
without specifying anyTargetActions
Target
as part of the declaredProject
.Expected behavior
If there are no precompiled or embedded frameworks, do not generate these empty build phases.
Screenshots
When comparing the diff with an existing project via
xcdiff
, the following is shown:Desktop:
Additional context
This was discussed in the public Tuist slack channel. Thanks to @kwridan for taking a look into it and suggesting. Although it's not a bug, it's definitely something that can be enhanced.
The text was updated successfully, but these errors were encountered: