Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuist shouldn't generate empty Embed Precompiled Frameworks and Embed Frameworks build phases #1181

Open
natanrolnik opened this issue Apr 2, 2020 · 1 comment
Labels
type:enhancement New feature or request

Comments

@natanrolnik
Copy link
Collaborator

Describe the bug

When creating a project with a target without any build phases (TargetActions), two empty build phases are added, unnecessarily: Embed Precompiled Frameworks (runScript) and Embed Frameworks (copyFiles).

To Reproduce

  1. Create a Target without specifying any TargetActions
  2. Add this Target as part of the declared Project.
  3. Check that two empty build phases are added: Embed Precompiled Frameworks (runScript) and Embed Frameworks (copyFiles).

Expected behavior
If there are no precompiled or embedded frameworks, do not generate these empty build phases.

Screenshots
When comparing the diff with an existing project via xcdiff, the following is shown:

Extra build phases

Desktop:

  • macOS 10.15.3

Additional context

This was discussed in the public Tuist slack channel. Thanks to @kwridan for taking a look into it and suggesting. Although it's not a bug, it's definitely something that can be enhanced.

@natanrolnik natanrolnik added the type:enhancement New feature or request label Apr 2, 2020
@kwridan
Copy link
Collaborator

kwridan commented Apr 15, 2020

Thanks for raising this @natanrolnik 👍

Having them there as empty build phases shouldn't be harmful. If you're interested in tackling this - the class responsible for adding those particular build phases is LinkGenerator

The thing that is worth checking is if any of the acceptance tests validate those empty build phases, they would potentially need to updated to perform a different check if we remove those phases completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants