-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for enabling/disabling synthesizing interfaces for resources in a per-project basis #2249
Comments
I was thinking if it would be better to specify the setting when defining the projects in the manifests instead of coupling the let config = Config(generationOptions: [.synthesizedResourceAccessorsDefault(true)])
let config = Config(generationOptions: [.synthesizedResourceAccessorsDefault(false)]) I hope it makes sense - let me know what you think 👍 |
If I wanted to take this on as a first time PR, do you have any suggestions on where to start looking or what you want the final API to look like? |
I agree with this
Maybe we could keep Did you have @sgrgrsn any specific API for how the On a different note: This is, indeed, a good first issue once we decide on the API. Feel free to come up with eg. the |
Could it be something like this, @fortmarek? Project(
name: "Project with resources",
synthesizedResourceAccessors: true
) Or do you think we should have something like the |
I believe that makes sense, I agree with this proposal 👍 |
I like that this can be defined at a per-project level. I think eventually we should remove those global options in favor of per-project definitions. |
I haven't forgotten about this, just been busy. I'll try to get in the slack tonight and see if I can get a start on how this would be setup. |
Fixed in #3963 getting rid of the |
Context 🕵️♀️
As @sgrgrsn brought up here, it'd be useful to allow disabling/enabling the synthesizing of interfaces for resources on a per-project basis.
What 🌱
We can extend the generation option to support passing a list of projects for which the synthesizing should be disabled/enabled. I think we can deprecate the existing
.disableSynthesizedResourceAccessors
in favor of something along the lines of:The text was updated successfully, but these errors were encountered: