Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment target not derived correctly for tuist test #2670

Closed
fortmarek opened this issue Mar 15, 2021 · 2 comments · Fixed by #5487
Closed

Deployment target not derived correctly for tuist test #2670

fortmarek opened this issue Mar 15, 2021 · 2 comments · Fixed by #5487
Assignees
Labels
bounty Resolving this issue is rewarded with a bounty: https://github.com/tuist/tuist/discussions/4982 type:bug Something isn't working

Comments

@fortmarek
Copy link
Member

Describe the bug

As describe here:

I was using the fixture ios_app_with_tests which doesn't leverage deploymentTarget property which the test service relies on to determine the minimum simulator version. Had to update the fixture to leverage it for the App and UI Tests targets to get the tests running. I locally have a 13.5 simulator available which is was defaulting to, but when a version isn't specified the minimum deployment target is the latest version (in my case 14.4).

It seems that the default platform for tests is not derived correctly when not specified in the manifest itself.

We should use the same default as tuist does when deploymentTarget is nil.

@fortmarek fortmarek added type:bug Something isn't working domain:automation labels Mar 15, 2021
@fortmarek fortmarek self-assigned this Mar 15, 2021
@fortmarek fortmarek mentioned this issue Mar 15, 2021
4 tasks
@danieleformichelli danieleformichelli added the bounty Resolving this issue is rewarded with a bounty: https://github.com/tuist/tuist/discussions/4982 label Jan 20, 2023
@leszko11
Copy link
Collaborator

Hey @fortmarek 👋

I would be happy to take a look, but I'm not sure what is the default in this case?

@fortmarek
Copy link
Member Author

fortmarek commented Sep 27, 2023

Hey @leszko11 👋

I think it might be set somewhere in Xcodeproj, you'd need to do some digging to find where it is actually specified. The deployment target can be nil, so the easiest way to get to the bottom of this is to take a fixture that doesn't have a deployment target (or update ios_app_with_tests not to have it) and see what gets generated. You run tuist through Xcode and step through what's happening.

Let me know if you need additional support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Resolving this issue is rewarded with a bounty: https://github.com/tuist/tuist/discussions/4982 type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants