Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Xcode Build Rules #2702

Closed
Gruppio opened this issue Mar 25, 2021 · 8 comments Β· Fixed by #5088
Closed

Add support for Xcode Build Rules #2702

Gruppio opened this issue Mar 25, 2021 · 8 comments Β· Fixed by #5088
Labels
bounty Resolving this issue is rewarded with a bounty: https://github.com/tuist/tuist/discussions/4982 type:enhancement New feature or request

Comments

@Gruppio
Copy link

Gruppio commented Mar 25, 2021

Context πŸ•΅οΈβ€β™€οΈ

It would be nice having the support for the Xcode build rules.
These are useful for project that use metal shaders for example.
Do you think that this feature is easy to implement ?

@fortmarek
Copy link
Member

Hi @Gruppio!

There is support for this in XcodeProj here, so that makes it a little bit easier.

Implementing this would consist of:

  • Proposing API to be used in ProjectDescription - most of it will more-or-less copy PBXBuildRule from XcodeProj but we should try to make optimizations and convenience types where possible.
  • Creating a new BuildRule type (with properties from the proposal), adding this to Project
  • Actually generating the build rules
  • Adding the build rules to copy files build phase (as per the example changes in .pbxproj below πŸ‘‡)

This is an example diff after I added an empty metal shader build rule:
image

If you would like to go ahead and implement this, I'd gladly give you some pointers.

@klememi
Copy link

klememi commented Apr 5, 2022

any update on this, please?

@fortmarek
Copy link
Member

We haven't had time to work on this feature, unfortunately. Would you like to give it a try @klememi? We can give you some pointers and introduce you to the project πŸ™‚

@klememi
Copy link

klememi commented Apr 8, 2022

Actually why not :) I can give it a try at least.

@fortmarek
Copy link
Member

Thanks @klememi πŸ‘Œ feel free to ping me in Slack if you run into any issues.

@zenangst
Copy link

Any movement on this issue? πŸ€”

@danieleformichelli
Copy link
Collaborator

Any movement on this issue? πŸ€”

Hello πŸ‘‹ would you like to try moving this forward? πŸš€

@zenangst
Copy link

@danyf90 ended up solving our case using https://github.com/tuist/XcodeProj directly. Don't know if I have time take on this task at the moment I'm afraid.

@danieleformichelli danieleformichelli added the bounty Resolving this issue is rewarded with a bounty: https://github.com/tuist/tuist/discussions/4982 label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Resolving this issue is rewarded with a bounty: https://github.com/tuist/tuist/discussions/4982 type:enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants