Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Codable API instead of JSONConvertible #59

Closed
ollieatkinson opened this issue Jul 20, 2018 · 1 comment
Closed

Use Codable API instead of JSONConvertible #59

ollieatkinson opened this issue Jul 20, 2018 · 1 comment
Labels
good first issue Good for newcomers type:enhancement New feature or request

Comments

@ollieatkinson
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently there's a custom implementation for JSON - is there a reason that we don't use the Codable API?

Describe the solution you'd like
Remove https://github.com/xcode-project-manager/xpm/blob/master/Sources/ProjectDescription/JSON.swift and make the models implement Codable API. (https://developer.apple.com/documentation/swift/codable)

Describe alternatives you've considered
The alternative is to avoid doing the work and keep the current system

@pepicrft
Copy link
Contributor

Not really. We could definitively use the Swift encoding/decoding APIs. I'd keep this as a low priority though.

@pepicrft pepicrft added type:enhancement New feature or request good first issue Good for newcomers labels Jul 21, 2018
@zdnk zdnk mentioned this issue Jul 25, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants