Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 5.4.2 fails to build on 32bit #44

Closed
eworm-de opened this issue Mar 19, 2023 · 2 comments
Closed

[Bug]: 5.4.2 fails to build on 32bit #44

eworm-de opened this issue Mar 19, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@eworm-de
Copy link

Describe the bug

Building the multilib package for Arch Linux (https://archlinux.org/packages/multilib/x86_64/lib32-xz/) fails. The lines producing the error did not change recently, but the version before (5.4.1) built without problems (and still builds with current toolchain).

Version

latest

Operating System

Arch Linux

Relevant log output

In file included from lz/lz_encoder_mf.c:16:
../../src/liblzma/common/memcmplen.h: In function 'lzma_memcmplen':
../../src/liblzma/common/memcmplen.h:92:36: error: conversion to 'uint32_t' {aka 'const unsigned int'} from 'int' may change the sign of the result [-Werror=sign-conversion]
   92 |                 const uint32_t x = 0xFFFF ^ _mm_movemask_epi8(_mm_cmpeq_epi8(
      |                                    ^~~~~~
@eworm-de eworm-de added the bug Something isn't working label Mar 19, 2023
@Larhzu Larhzu closed this as completed in dfe1710 Mar 19, 2023
Larhzu added a commit that referenced this issue Mar 19, 2023
Thanks to Christian Hesse for reporting the issue.
Fixes: #44
@Larhzu
Copy link
Member

Larhzu commented Mar 19, 2023

Sorry. :-( I added a few warning flags since I thought I had silenced them all.

Arch uses --enable-werror so that's why warnings make the build fail. This is good for testing :-) although it can cause annoyances like this. It was only recently that -Wno-format-truncation could be removed from the PKGBUILD file in Arch.

It's fixed in master and v5.4 now. Thanks!

@eworm-de
Copy link
Author

Thanks a lot for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants