-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For lasse #123
Closed
Closed
For lasse #123
Commits on Jun 3, 2024
-
xz: list: suppress -Wformat-nonliteral for Solaris
Solaris' GCC can't understand that our use is fine, unlike modern compilers: ``` list.c: In function 'print_totals_basic': list.c:1191:4: error: format not a string literal, argument types not checked [-Werror=format-nonliteral] uint64_to_str(totals.files, 0)); ^~~~~~~~~~~~~ cc1: all warnings being treated as errors ``` It's presumably because of older gettext missing format attributes. This is with `gcc (GCC) 7.3.0`.
Configuration menu - View commit details
-
Copy full SHA for 4e38b04 - Browse repository at this point
Copy the full SHA 4e38b04View commit details -
Inspired by RsyncProject/rsync@3f2a38b. It runs on Solaris 5.11 via a VirtualBox VM.
Configuration menu - View commit details
-
Copy full SHA for 34f47a4 - Browse repository at this point
Copy the full SHA 34f47a4View commit details -
xz is already part of oss-fuzz, but oss-fuzz provides & encourages [0] its 'CIFuzz' service to test individual PRs and commits. I think it can also run on a schedule but I haven't added that in (yet?) [0] https://google.github.io/oss-fuzz/getting-started/continuous-integration/
Configuration menu - View commit details
-
Copy full SHA for 42c7cd9 - Browse repository at this point
Copy the full SHA 42c7cd9View commit details -
The only non-trivial part here was macOS where 'gcc' is actually Apple Clang by default, so we have to go out of our way to get GCC from Homebrew, and do the same for Clang.
Configuration menu - View commit details
-
Copy full SHA for 384c964 - Browse repository at this point
Copy the full SHA 384c964View commit details -
ci: speed up Valgrind job by using --trace-children-skip-by-arg=...
This addresses the issue I mentioned in 6c095a9 and speeds up the Valgrind job a bit, because non-xz tools aren't run unnecessarily with Valgrind by the script tests.
Configuration menu - View commit details
-
Copy full SHA for 1ca4e76 - Browse repository at this point
Copy the full SHA 1ca4e76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 539b35c - Browse repository at this point
Copy the full SHA 539b35cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fa60d1 - Browse repository at this point
Copy the full SHA 5fa60d1View commit details -
Without "set -e" the job will always be successful. See vmactions/freebsd-vm#72
Configuration menu - View commit details
-
Copy full SHA for c515927 - Browse repository at this point
Copy the full SHA c515927View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50f2a84 - Browse repository at this point
Copy the full SHA 50f2a84View commit details -
Closes: tukaani-project#116
Configuration menu - View commit details
-
Copy full SHA for 556b768 - Browse repository at this point
Copy the full SHA 556b768View commit details -
ci: don't pin official GH actions via commit, just tag
There's no real value in doing it via commit for official GH actions. We can keep using pinned commits for unofficial actions. It's hassle for no gain. Maybe going forward we can limit this further by only being paranoid for the jobs with any access to tokens.
Configuration menu - View commit details
-
Copy full SHA for 455fabd - Browse repository at this point
Copy the full SHA 455fabdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.