Support build target wasm32-unknown-unknown
in clang when ENABLE_THREADS=OFF
#57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the review #56 yesterday!
I tried another approach, could you please review this one?
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Related Issue URL:
#56
What is the new behavior?
__wasm__
macro when the build target is set to wasm32 with clang.This change allows
liblzma
to be built with the platform-independentwasm32-uknown-unknown
target.I believe this exclusion will work in the same way as the build when targeting Windows, so it will minimize unexpected changes.
Does this introduce a breaking change?
Other information
Build tested on docker
Dockerfile
$ docker build -t xz .
If you need, you can see the predefined macros when targeting wasm32 in clang by following commands
or if you want to check with the latest wasi-sdk clang