Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing semicolon #69

Closed
wants to merge 1 commit into from
Closed

Conversation

Jamaika1
Copy link
Contributor

fastpos.h:94:28: error: expected ';' before 'extern'
   94 | lzma_attr_visibility_hidden
      |                            ^
      |                            ;
   95 | extern const uint8_t lzma_fastpos[1 << FASTPOS_BITS];
      | ~~~~~~

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and without warnings or errors
  • All previous and new tests pass

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming, typo fix)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Related Issue URL:

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

```
fastpos.h:94:28: error: expected ';' before 'extern'
   94 | lzma_attr_visibility_hidden
      |                            ^
      |                            ;
   95 | extern const uint8_t lzma_fastpos[1 << FASTPOS_BITS];
      | ~~~~~~
```
@Larhzu Larhzu closed this in 4600704 Oct 31, 2023
Larhzu added a commit that referenced this pull request May 7, 2024
The macro lzma_attr_visibility_hidden has to be defined to make
fastpos.h usable. The visibility attribute is irrelevant to
fastpos_tablegen.c so simply #define the macro to an empty value.

fastpos_tablegen.c is never built by the included build systems
and so the problem wasn't noticed earlier. It's just a standalone
program for generating fastpos_table.c.

Fixes: #69
Thanks to GitHub user Jamaika1.

(cherry picked from commit d90ed84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant