BL-1823 Extend timeout time to 10 seconds #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomadicoder
requested review from
ebtoner,
dkinzer,
cdoyle-temple and
sensei100
|
@nomadicoder -- In the description, you mention that this is for a Primo timeout. While this file is for the Primo article document, the actual code for the lookup in question is related to LibKey, which is a different third-party service that we use from Third Iron for the "View Full Text PDF" link. I think that David mentioned that increasing this timeout could potentially affect performance, so I hestiate to make the timeout 10 seconds. @dkinzer -- do you think a smaller increase of 1 or 2 seconds would be okay? Alternatively, we could just have this fail more gracefully. |
ebtoner
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses intermittent timeout with Primo Central