BL-1840 Make web_concurrency configurable #4249
Conversation
| RUBY_YJIT_ENABLE="1" | ||
|
|
||
| USER root | ||
|
|
||
| ARG SECRET_KEY_BASE | ||
| ARG WEB_CONCURRENCY |
There was a problem hiding this comment.
I don't think just a docker build arg alone will work because build args go away after the build and it needs to stay as an system env. I was thinking maybe a combo of a build arg plus the env would do the trick. though, i'm not 100 sure.
There was a problem hiding this comment.
@dkinzer I added the ENV Variable to the charts deployment template. Is that not enough?
There was a problem hiding this comment.
Unfortunately it's not because the point of this is to make it configurable locally too and the chart change would just manage the deployed change. Also ARG doesn't work alone because ARG is supposed to be exclusively for branching the build process. Hmm.. Maybe we can just add --env to run in Makefile and that would be enough for local override?
There was a problem hiding this comment.
@dkinzer I added it as an env var to the make run command. I did run it locally and the variable was set to what I expected it to be.
I will follow up this PR with one to charts to add the environment variable there.