Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BL-1829 update digital collections results on bento page #4298

Merged

Conversation

cdoyle-temple
Copy link
Contributor

No description provided.

@ebtoner
Copy link
Contributor

ebtoner commented Mar 12, 2024

@cdoyle-temple -- This is definitely a step in the right direction, but reading the code, I think that we're still querying https://digital.library.temple.edu/digital/bl/dmwebservices/index.php?q=dmGetCollectionList/json three times, once per result item. Can we update this to do the collection query once per bento search and then refer back to the same json when matching the collection alias to the collection name for each result?

@ebtoner
Copy link
Contributor

ebtoner commented Mar 14, 2024

@cdoyle-temple -- if it's okay with you, I will merge this for now and then follow up on limiting https://digital.library.temple.edu/digital/bl/dmwebservices/index.php?q=dmGetCollectionList/json to one call in a separate PR.

@ebtoner ebtoner merged commit 1b1ddc2 into main Mar 14, 2024
3 checks passed
@ebtoner ebtoner deleted the BL-1829-update-digital-collections-results-on-bento-page branch March 14, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants