Skip to content

Commit

Permalink
Merge pull request #1184 from pdrvsky/fix/metadata-request-nullable-a…
Browse files Browse the repository at this point in the history
…rray

Change sent metadata topic array to be nullable (versions 1, 2 and 3)
  • Loading branch information
Nevon committed Feb 8, 2022
2 parents 496421c + 89af3ab commit 5fe4004
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
12 changes: 10 additions & 2 deletions src/protocol/requests/metadata/v1/request.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
const requestV0 = require('../v0/request')
const Encoder = require('../../../encoder')
const { Metadata: apiKey } = require('../../apiKeys')

/**
* Metadata Request (Version: 1) => [topics]
* topics => STRING
*/

module.exports = ({ topics }) => Object.assign(requestV0({ topics }), { apiVersion: 1 })
module.exports = ({ topics }) => ({
apiKey,
apiVersion: 1,
apiName: 'Metadata',
encode: async () => {
return new Encoder().writeNullableArray(topics)
},
})
4 changes: 2 additions & 2 deletions src/protocol/requests/metadata/v2/request.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const requestV0 = require('../v0/request')
const requestV1 = require('../v1/request')

/**
* Metadata Request (Version: 2) => [topics]
* topics => STRING
*/

module.exports = ({ topics }) => Object.assign(requestV0({ topics }), { apiVersion: 2 })
module.exports = ({ topics }) => Object.assign(requestV1({ topics }), { apiVersion: 2 })
4 changes: 2 additions & 2 deletions src/protocol/requests/metadata/v3/request.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const requestV0 = require('../v0/request')
const requestV1 = require('../v1/request')

/**
* Metadata Request (Version: 3) => [topics]
* topics => STRING
*/

module.exports = ({ topics }) => Object.assign(requestV0({ topics }), { apiVersion: 3 })
module.exports = ({ topics }) => Object.assign(requestV1({ topics }), { apiVersion: 3 })

0 comments on commit 5fe4004

Please sign in to comment.