Merge pull request #1426 from tulios/validate-manual-replica-assignment

Verify creating topic with manual replica assignment
tulios · Jul 26, 2022 · ff6be44 · ff6be44
2 parents 8a799c6 + a6f60ad
commit ff6be44
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/admin/__tests__/createTopics.spec.js b/src/admin/__tests__/createTopics.spec.js
@@ -93,6 +93,18 @@ describe('Admin', () => {
       ).resolves.toEqual(true)
     })
 
+    test('creating topic with manual replica assignment', async () => {
+      admin = createAdmin({ cluster: createCluster(), logger: newLogger() })
+
+      await admin.connect()
+      await expect(
+        admin.createTopics({
+          waitForLeaders: false,
+          topics: [{ topic: topicName, replicaAssignment: [{ partition: 0, replicas: [0, 1] }] }],
+        })
+      ).resolves.toEqual(true)
+    })
+
     test('retries if the controller has moved', async () => {
       const cluster = createCluster()
       const broker = { createTopics: jest.fn(() => true) }

diff --git a/types/index.d.ts b/types/index.d.ts
@@ -238,7 +238,7 @@ export interface ITopicConfig {
   topic: string
   numPartitions?: number
   replicationFactor?: number
-  replicaAssignment?: object[]
+  replicaAssignment?: ReplicaAssignment[]
   configEntries?: IResourceConfigEntry[]
 }