Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message timestamp on produce v3 #188

Merged
merged 2 commits into from
Oct 29, 2018

Conversation

tulios
Copy link
Owner

@tulios tulios commented Oct 29, 2018

Produce v3 isn't filtering undefined timestamps and is sending timestamp 0 (NaN converted) for all messages. This error should affect features that rely on the message timestamps and topics with "log.message.timestamp.difference.max.ms", the producer will throw INVALID_TIMESTAMP error.

Example on how to create a topic with the timestamp difference configuration:

await admin.createTopics({
    waitForLeaders: true,
    topics: [
      {
        topic: 'topic-with-max-timstamp-difference',
        numPartitions: 2,
        configEntries: [
          {
            name: 'message.timestamp.difference.max.ms',
            value: '604800000', // 7 days
          },
        ],
      },
    ],
  })

@tulios tulios requested a review from Nevon October 29, 2018 10:08
@tulios tulios merged commit e452afd into master Oct 29, 2018
@Nevon Nevon deleted the fix-message-timestamp-on-produce-v3 branch October 29, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants