Add transactional attributes to record batch #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to protocol producer v3 and RecordBatch
tulios
added this to To do
in Exactly Once Delivery and Transactional Messaging
via automation
tulios
moved this from To do
to In progress
in Exactly Once Delivery and Transactional Messaging
ianwsperber
suggested changes
Nov 7, 2018
There was a problem hiding this comment.
@tulios Looks good! Just one question about the compression mask.
ianwsperber
approved these changes
Nov 8, 2018
|
Awesome, thanks @tulios, LGTM! |
Exactly Once Delivery and Transactional Messaging
automation
moved this from In progress
to Done
Nov 8, 2018
|
This resolves #196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready now; it's missing a test for the producer with the transactional flag on but we will have to wait for EOS support to test it properly.