Add in typescript declaration file. #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Transactions documentation to correctly reflect setup process for transactional producer.
|
@talam thanks for the PR |
tulios
requested changes
May 14, 2019
tulios
approved these changes
May 15, 2019
Nevon
reviewed
May 15, 2019
|
This is an amazing effort. Thank you so much! |
Nevon
approved these changes
May 15, 2019
|
I think Azure pipelines is having some issues; I will get this build green and merge. Thanks. |
|
Nice work! |
|
@micaelmbagira I will probably bundle this change with some other issues so it might take a little while. You can try it out by using the commit number: yarn add https://github.com/tulios/kafkajs.git#054ef5042a99cca6af97bd90e43facadcc01dd3e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added in a typescript declaration file and also updated the transactions documentation to correctly reflect the setup process for transactional producer.