Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose consumer paused partitions #444

Merged
merged 6 commits into from
Jul 25, 2019
Merged

Expose consumer paused partitions #444

merged 6 commits into from
Jul 25, 2019

Conversation

tulios
Copy link
Owner

@tulios tulios commented Jul 24, 2019

I made a small change to the subscription state, @JaapRood can you take a look? I am filtering out paused topics without active partitions on the consumer. The method will always return an empty array if the consumer group isn't initialized, I think it makes more sense than throwing the error on this case.

CC @terebentina

Copy link
Collaborator

@JaapRood JaapRood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since it already resolves against the active partitions and only returns for those topics, it makes sense to only return active partitions, too.

@tulios tulios merged commit f28bd0e into master Jul 25, 2019
@tulios tulios deleted the expose-paused-partitions branch July 25, 2019 12:38
@tulios
Copy link
Owner Author

tulios commented Jul 25, 2019

I am excited to see if the pre-release is going to work. 😄

@JaapRood
Copy link
Collaborator

JaapRood commented Jul 25, 2019

No such luck? 😂😬😭

@tulios
Copy link
Owner Author

tulios commented Jul 25, 2019

yml pipelines are hard :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants