Handle receiving empty member assignment #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankon
reviewed
Nov 28, 2019
…fkajs into handle-empty-member-assignment
ankon
reviewed
Nov 28, 2019
types/index.d.ts
Outdated
| @@ -338,7 +338,7 @@ export type MemberAssignment = { | |||
|
|
|||
| export const AssignerProtocol: { | |||
| MemberMetadata: ISerializer<MemberMetadata> | |||
| MemberAssignment: ISerializer<MemberAssignment> | |||
| MemberAssignment: ISerializer<MemberAssignment | null> | |||
There was a problem hiding this comment.
That means MemberAssignment#encode() would need to handle null as well now, right?
There was a problem hiding this comment.
Right! Took me a bit to see what you meant, but yes indeed, it would mean that encode would also need to handle receiving null.
I changed it now so that only the decode has a nullable return type.
|
@Nevon can you add an integration test? |
The test assigner only returns assignments for the first member of the group, and not the second one. Without #567 the second consumer will crash when trying to decode the missing assignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #550.
This is a slightly different approach than #551 because I wanted to make sure that the MemberAssignment decoder could handle receiving a buffer with insufficient data, instead of expecting the caller to do the checking for it.