Only wait for the lock when there was actually batches enqueued #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for fetch to have requests with no batches: If a seek happens between `fetch` processing the known seek offsets and the actual request checking the partitions and skipping any that have a seek offset _at that point_ the protection against empty requests isn't enough. In this case we must not wait for the lock here, because there won't be any task that can unlock it, and in result we end up with never fetching again for this specific group. This fixes the issue seen with https://kafkajs.slack.com/archives/CF6RFPF6K/p1584530032102400
|
Nice find, thanks for investigating that so thoroughly! |
Nevon
approved these changes
Mar 19, 2020
|
That cannot have been an easy thing to find. Nice! |
tulios
approved these changes
Mar 20, 2020
|
@ankon can you merge master here so we can merge? |
|
Sure :) |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for fetch to have requests with no batches: If a seek happens
between
fetchprocessing the known seek offsets and the actual request checkingthe partitions and skipping any that have a seek offset at that point the protection
against empty requests isn't enough.
In this case we must not wait for the lock here, because there won't be any task
that can unlock it, and in result we end up with never fetching again for this specific
group.
This fixes the issue seen with https://kafkajs.slack.com/archives/CF6RFPF6K/p1584530032102400