Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the type of the PartitionAssigner #675

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Fix the type of the PartitionAssigner #675

merged 1 commit into from
Mar 24, 2020

Conversation

ankon
Copy link
Contributor

@ankon ankon commented Mar 23, 2020

This is not supposed to be a constructor (something to be called with new), but rather it is
just a simple callable thing.

See

kafkajs/src/consumer/index.js

Lines 48 to 51 in 3601d7a

const assigners = partitionAssigners.map(createAssigner =>
createAssigner({ groupId, logger, cluster })
)

@ankon
Fix the type of the PartitionAssigner
e6185f8 
This is not supposed to be a constructor (something to be called with `new`), but rather it is
just a simple callable thing.
@Nevon Nevon merged commit c7ed777 into tulios:master Mar 24, 2020
@ankon ankon deleted the pr/type-partition-assigner branch March 24, 2020 08:40
@ankon ankon mentioned this pull request Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ankon @Nevon