Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin.describeGroups #742

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Add admin.describeGroups #742

merged 2 commits into from
Jun 8, 2020

Conversation

Nevon
Copy link
Collaborator

@Nevon Nevon commented Jun 3, 2020

Implements a new method on the Admin client, describeGroups. It works the same as the equivalent method on the Consumer, except it allows you to query by multiple groupIds.

Fixes #731

Implements a new method on the Admin client, `describeGroups`. It works the same
as the equivalent method on the Consumer, except it allows you to query by multiple
groupIds.

Fixes #731
@Nevon Nevon requested review from tulios and JaapRood June 3, 2020 15:28
Copy link
Collaborator

@JaapRood JaapRood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only thing I think we might be missing is providing the leader / partition assignor in the result. If I remember correctly the memberId of the consumer who was elected is what's used elsewhere as well, would that be appropriate?

@Nevon
Copy link
Collaborator Author

Nevon commented Jun 5, 2020

And before I forget, updating the TS type definitions.

EDIT: Done!

@Nevon
Copy link
Collaborator Author

Nevon commented Jun 7, 2020

The only thing I think we might be missing is providing the leader / partition assignor in the result. If I remember correctly the memberId of the consumer who was elected is what's used elsewhere as well, would that be appropriate?

We don't provide this in consumer.describeGroup, and I don't think we actually have a way to get it, since it's not part of the DescribeGroups response. The only place I can find with that information is in the JoinGroup response, which isn't relevant to the admin client.

@Nevon Nevon requested a review from JaapRood June 7, 2020 16:40
Copy link
Collaborator

@JaapRood JaapRood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Nevon Nevon merged commit d26b941 into master Jun 8, 2020
@Nevon Nevon deleted the admin-describe-groups branch June 8, 2020 08:16
@tzachshabtay
Copy link

Thanks for the quick turnaround! When can I expect to see a new package on npm? @Nevon @JaapRood

@Nevon
Copy link
Collaborator Author

Nevon commented Jun 9, 2020

There's a new beta release out already. I can't make any promises regarding when we'll make the next stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin API- Describe consumer groups
3 participants