-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admin.describeGroups
#742
Conversation
Implements a new method on the Admin client, `describeGroups`. It works the same as the equivalent method on the Consumer, except it allows you to query by multiple groupIds. Fixes #731
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The only thing I think we might be missing is providing the leader / partition assignor in the result. If I remember correctly the memberId
of the consumer who was elected is what's used elsewhere as well, would that be appropriate?
And before I forget, updating the TS type definitions. EDIT: Done! |
We don't provide this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There's a new beta release out already. I can't make any promises regarding when we'll make the next stable release. |
Implements a new method on the Admin client,
describeGroups
. It works the same as the equivalent method on the Consumer, except it allows you to query by multiple groupIds.Fixes #731