Avoid repeated costly copies of buffers when working with encoders #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using `Buffer.concat` whenever writing into the encoder, and thereby copying the byte contents of earlier added content potentially many times, this commit changes the encoder to use a bigger pre-allocated buffer to write into directly. If that buffer fills up it a new one will be created and the old contents copied into that.
Nevon
reviewed
Jul 20, 2020
|
Cool! I've been wanting to do this forever, but never got around to finishing it up. I just have one question about the implementation, but I'm fine with merging either way. |
Nevon
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
Buffer.concatwhenever writing into the encoder, and thereby copying the bytecontents of earlier added content potentially many times, this commit changes the encoder to use
a bigger pre-allocated buffer to write into directly. If that buffer fills up it a new one will be created
and the old contents copied into that.
This is somewhat related to #475. In our production environment I can see improvements with this change in the order of maybe ~10% less GC reclaimed bytes/s, which does help.