Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only commit offsets on eachMessage failures if autoCommit is enabled #866

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Only commit offsets on eachMessage failures if autoCommit is enabled #866

merged 1 commit into from
Sep 11, 2020

Conversation

tulios
Copy link
Owner

@tulios tulios commented Sep 11, 2020

Currently, eachMessage is not respecting the autoCommit property and always committing offsets on failures. This is a simplified PR for #782

@tulios tulios requested a review from Nevon September 11, 2020 12:08
@tulios tulios merged commit bf598cd into master Sep 11, 2020
@tulios tulios deleted the skip-commit-on-failure-when-autocommit-false branch September 11, 2020 12:16
@tulios tulios mentioned this pull request Sep 11, 2020
Closed
@Nevon Nevon mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nevon Nevon Nevon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tulios @Nevon