Commits on Oct 29, 2020

1. Move the 'metadata about the API' tests from the protocol request.spe… …

   …c.js files into the requests test
   
   The metadata check is required for all request implementations, and having it separate in each test
   just increases the chance for not having it everywhere ... which is exactly the situation right now.
   This commit _increases_ test coverage therefore, by now making sure the test is run for each request.

   

   ankon committed Oct 29, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 2047b83
   • Browse repository at this point

   Copy the full SHA

   2047b83 View commit details

   Browse the repository at this point in the history

2. Complete the implementation for client-side throttling in all current… …

   …ly supported APIs
   
   This commit accomplishes a few things:
   1. Ensure that iff `clientSideThrottleTime` is set, `throttleTime` is set to 0.
      This was the original intent of the commit adding support for client-side throttling,
      so that it is very obvious who did the throttling.
   2. Add the missing API versions for the client-side throttling bump in a single commit, rather
      than hoping that they appear over time. This allows to align the code for these to be a version
      of "decode the response with the previous version, and then move the throttleTime to
      clientSideThrottleTime".
   3. Update the tests to consider `clientSideThrottleTime` optionally, so that the tests should
      pass on quite a few previous Kafka versions.

   

   ankon committed Oct 29, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 68c84d2
   • Browse repository at this point

   Copy the full SHA

   68c84d2 View commit details

   Browse the repository at this point in the history