Refresh metadata on any connection error #958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we get a connection timeout, we currently don't refresh metadata in all cases. Fixes #950.
Co-authored-by: Sam <me@smartin.io>
|
The test that was checking that the broker connection was rebuilt on ILLEGAL_SASL_STATE was actually invalid. It was throwing a generic KafkaJSConnectionError - which is retriable - when in reality there would be a non-retriable KafkaJSProtocolError. Updating Now the test is updated so that on ILLEGAL_SASL_STATE we rebuild the connection and throw a new retriable version of the protocol error so that the connection gets retried. |
|
This PR is superseded by #962 as it moves the responsibility of refreshing metadata into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we get a connection timeout, we currently don't refresh metadata in all cases, only if we get an
ECONNREFUSED.Fixes #950 with the help of @smartinio.