Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there any reason why SimpleCharStream and JavaCharStream buffer themselves? #13

Closed
phax opened this issue Jan 15, 2018 · 2 comments
Closed

Is there any reason why SimpleCharStream and JavaCharStream buffer themselves? #13

phax opened this issue Jan 15, 2018 · 2 comments
Assignees
@phax
Labels
duplicate question

Comments

@phax
Copy link
Collaborator

phax commented Jan 15, 2018

Why don't they use PushBackReader?
This whole setup seems to be a bit overly complex (or grown over time?).
I would like to cut this down to a simple reader using a PushBackReader acting on top of a BufferedReader or so

Any comments @matozoid @ftomasetti
@phax phax added the question label Jan 15, 2018
@phax phax self-assigned this Jan 15, 2018
@matozoid
Copy link

I really have no idea!

@phax
Copy link
Collaborator Author

phax commented May 2, 2019

Basically the same issue as #21

@phax phax closed this as completed May 2, 2019
@phax phax added the duplicate label May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
duplicate question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matozoid @phax