Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleCharStream.ExpandBuff has O(N^2) behavior for large tokens #21

Open
phax opened this issue Oct 26, 2018 · 9 comments
Open

SimpleCharStream.ExpandBuff has O(N^2) behavior for large tokens #21

phax opened this issue Oct 26, 2018 · 9 comments
Assignees

Comments

@phax
Copy link
Collaborator

phax commented Oct 26, 2018

Same as javacc#72 - makes sense.

@inponomarev
Copy link
Collaborator

Hello, you might want to take a look at javacc#85 and updates in javacc#72 issue.

@phax
Copy link
Collaborator Author

phax commented Mar 23, 2019

I do :) waiting for the link to a nice StringReader based implementation ;)

@phax phax self-assigned this Mar 25, 2019
@inponomarev
Copy link
Collaborator

inponomarev commented Apr 13, 2019

Hi @phax ! It seems that there won't be any answer.

What do you think about javacc#85 and javacc#71 in your fork? If I ported these PRs to your fork, would you like to merge them?

@phax
Copy link
Collaborator Author

phax commented Apr 13, 2019

Sure :)

@phax
Copy link
Collaborator Author

phax commented May 2, 2019

JavaCC PR 71 is in

@inponomarev
Copy link
Collaborator

Wow, great!! Time has come to consider testing my projects with ParserGeneratorCC instead of JavaCC.

@phax
Copy link
Collaborator Author

phax commented May 3, 2019

It should be easily usable with the ph-javacc-maven-plugin (which was updated to 4.1.3)

@stale
Copy link

stale bot commented Aug 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@phax
Copy link
Collaborator Author

phax commented May 13, 2020

@inponomarev I didn't take your fix because I don't fully understand what it does. What I did instead in the 1.1.3 release is not to use a constant addition for the buffer size, but instead double the buffer size every time - that should ease your pain a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants