Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mispelling Ctrl+<other> key binding causes crash; maybe just report on console? #420

Open
goodboy opened this issue Apr 20, 2023 · 0 comments

Comments

@goodboy
Copy link

goodboy commented Apr 20, 2023

I misspelled Ctrl when mucking with custom kbs..

visual:
  'Ctl+Space': select_prev

Causes following stack trace (as dumped to /tmp/):

failed to parse keybinding Ctl+Space -> select_prev: invalid key event
goroutine 1 [running]:
runtime/debug.Stack()
	/usr/lib/go/src/runtime/debug/stack.go:24 +0x65
maunium.net/go/gomuks/debug.PrettyPanic({0xfa59a0, 0xc00042df80})
	/home/goodboy/repos/gomuks/debug/debug.go:133 +0x19a
maunium.net/go/gomuks/debug.Recover()
	/home/goodboy/repos/gomuks/debug/debug.go:107 +0x5a
panic({0xfa59a0, 0xc00042df80})
	/usr/lib/go/src/runtime/panic.go:884 +0x213
maunium.net/go/gomuks/config.parseKeybindings(0xc000473e30)
	/home/goodboy/repos/gomuks/config/config.go:252 +0x215
maunium.net/go/gomuks/config.(*Config).LoadKeybindings(0xc0001578c0)
	/home/goodboy/repos/gomuks/config/config.go:280 +0x15e
maunium.net/go/gomuks/config.(*Config).LoadAll(0xc0001578c0)
	/home/goodboy/repos/gomuks/config/config.go:203 +0x252
main.NewGomuks(0x114fe78, {0xc00002f7e0, 0x1c}, {0xc00002ca20, 0x21}, {0xc00002f820, 0x1b}, {0xc00002ab10, 0x17})
	/home/goodboy/repos/gomuks/gomuks.go:88 +0x191
main.main()
	/home/goodboy/repos/gomuks/main.go:106 +0x65e

Feels like this could be better if just reported to console so a user doesn't have to dig through a stack trace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant