Allow emojis in reactions #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
approved these changes
Mar 30, 2022
|
This makes it faster to type emojis whose complete name is the prefix to other emojis. Take I must confess I did not notice emoji auto-completion before your comment, which is why I sent this patch. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy-pasted the extract from
SendMessageHTMLthat does the same thing. This patch has not been tested yet as I do not have a Go development environment accessible currently. I will do so in the upcoming days.My doubts would be about whether this transformation should come before or after the debug printing. Any opinions?
Thanks for gomuks, it has been really enjoyable to use!