Async uploads rate limiting improvements #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sumner Evans <sumner@beeper.com>
* Explicitly specify that M_NOT_FOUND should be used for expired media * Explicitly specify that M_FORBIDDEN should be used when a user other than the one who created the media ID tries to upload to it * Remove content-length failure note Signed-off-by: Sumner Evans <sumner@beeper.com>
Signed-off-by: Sumner Evans <sumner@beeper.com>
…rver Signed-off-by: Sumner Evans <sumner@beeper.com>
Signed-off-by: Sumner Evans <sumner@beeper.com>
Signed-off-by: Sumner Evans <sumner@beeper.com>
Signed-off-by: Sumner Evans <sumner@beeper.com>
… than start Signed-off-by: Sumner Evans <sumner@beeper.com>
sumnerevans
force-pushed
the
async-uploads-rate-limiting-improvements
branch
from
8e05c9e
to
52d0abd
Compare
Namely, allowing a limited number of concurrent uploads Signed-off-by: Sumner Evans <sumner@beeper.com>
sumnerevans
force-pushed
the
async-uploads-rate-limiting-improvements
branch
from
52d0abd
to
011031b
Compare
|
lgtm! |
Signed-off-by: Sumner Evans <sumner@beeper.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #2. If the changes made here are too controversial,only #2 should be merged. This should address all of the concerns that Travis had, though.