Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update group participants #495

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Update group participants #495

merged 8 commits into from
Dec 6, 2023

Conversation

arugaz
Copy link
Contributor

@arugaz arugaz commented Nov 20, 2023 •
edited
Loading

Fixes #324

@arugaz
Copy link
Contributor Author

arugaz commented Nov 20, 2023 •
edited
Loading

Closes #421

@arugaz arugaz marked this pull request as ready for review November 20, 2023 22:06
@arugaz
Copy link
Contributor Author

arugaz commented Nov 20, 2023

@tulir what do you think? UpdateGroupParticipants will break the old function

@arugaz
Copy link
Contributor Author

arugaz commented Nov 21, 2023

Closes #441, Closes #462

@tulir
Copy link
Owner

tulir commented Nov 27, 2023

Should definitely break it since the old one doesn't work properly

@tulir tulir self-requested a review November 27, 2023 22:04
@arugaz
Copy link
Contributor Author

arugaz commented Dec 5, 2023

@tulir could you please merge this, is there anything i need to change?

@tulir
Copy link
Owner

tulir commented Dec 5, 2023

Might have time to look at this tomorrow

tulir
tulir approved these changes Dec 6, 2023
View reviewed changes
Copy link
Owner

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to reuse types.GroupParticipant and parse the AddRequest properly, otherwise looked good already

@tulir tulir merged commit 6566a05 into tulir:main Dec 6, 2023
2 checks passed
@arugaz arugaz deleted the group branch December 8, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update a batch of group participants dosen't work
2 participants
@arugaz @tulir