Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom bar paging #302

Open
Goranaws opened this issue Apr 11, 2018 · 8 comments
Open

Custom bar paging #302

Goranaws opened this issue Apr 11, 2018 · 8 comments
Assignees
Labels
enhancement A new feature

Comments

@Goranaws
Copy link
Contributor

I have my method functional. Right now, it needs to be integrated into the main addon options, but it's testable in game.

https://github.com/Goranaws/Dominos/blob/master/bars/barStates.lua

To use: click on the editbox, you can type what you want, or use the menu that will pop up. Clicking anything on the menu will build the state for you. once you have what you want to test, click the "+" and got to the paging menu on a bar.

@Tuller Tuller self-assigned this Apr 11, 2018
@Tuller Tuller added the enhancement A new feature label Apr 11, 2018
@Tuller
Copy link
Member

Tuller commented Apr 11, 2018

I still need to actually look at this.

@Goranaws
Copy link
Contributor Author

It's better that you hadn't before now, it was rather a mess before. I'm bad for making code soup...

@Goranaws
Copy link
Contributor Author

Just did some work on this. code is cleaner, and semi-integrated into the options panel. Right clicking the minimap button now brings it up with the main options. Needs some touch-up, and maybe a good bit of Tuller TLC.

@Tuller
Copy link
Member

Tuller commented Apr 19, 2018

The addon menu bit doesn't actually work for me at the moment (I think its dependent on a dropdown menu implementation that's not there). I really need to draw out some mockups for what I want to help me figure out how I want it to look/function.

@Goranaws
Copy link
Contributor Author

Woops, forgot I'm using lib_uidropdownmenu... Had some bugs that it resolved. Deafult ui dorpdowns are leaky. I've continued working on it, so I'll post my current effort with lib_uidropdownmenu.

@Goranaws
Copy link
Contributor Author

Just to explain my implementation... My idea is that having the dropdown will assist people who aren't macro savy.

One thing I would like to add is the double check that the show states gives... It tells you via the chat window if your macros are good. I'd like to add that feature

@Goranaws
Copy link
Contributor Author

Just uploaded my latest. Everything should work as expected now.

@Tuller
Copy link
Member

Tuller commented Apr 23, 2018

I'll try and look at it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature
Projects
None yet
Development

No branches or pull requests

2 participants