-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dragonflight] Edit Mode Related Execution Path Taint #701
Comments
Always happens after a pet battle, no combat involved. |
Heyho, |
I'm still having a ton of trouble reproducing this one. At this point, I need people to do the the following:
|
Just found this: 1/17 12:01:21.068 Execution tainted by Dominos while reading DominosFrameextra - Interface/FrameXML/EditModeSystemTemplates.lua:449 ExtraAbilityContainer:SetSnappedToFrame() Which is curious because I don't even have the ExtraAbility module installed. |
May be worth removing the extra bar from Dominos.toc: |
Thanks for the tip! |
To add some additional Info from me thus far: So yeah pretty much unplayable so i kinda had to uninstall it. |
Uploaded taint.log requested by Tuller. My addons: |
Weirdly I seem to only get this error on my hunter and not rogue, druid, shaman, warlock, mage. But it happens on my hunter consistently, so it's easy for me to reproduce. Let me know if you want me to perform any tests. I'm motivated to get this fixed. |
I can 100% recreate the error by going into a dungeon, changing my talents, then tryin to hit something with one of my macro keys (keyboard press only. mouse clicking seems to work fine). Addons: |
Just to add another data point. I'm experiencing the same issues recently and was able to capture the following log. I reloaded immediately after getting the My addons!BugGrabber |
Is there any solution related to this issue? Kinda sad to uninstall an addon that I have been using for so long |
The only real solution to the problem is to not use Blizzards code for action buttons. That itself has issues, as click and hold casting is not possible with custom code. |
Without any insight into the cause of the issue and just to confirm my understanding of this; should I take this as 'if you want click and hold casting, and to not have this bug - you have to use vanilla action bars'. If one is ready to disregard click and hold stuff, I guess there are alternatives out there? |
Yes, I could simply just write my own action button implementation at that point (this is what Bartender does via LibActionButton). |
So, the solution could be for you to implement your own action button code for all classes except evokers, and then create "dominos for evokers" with the blizzard code, and everyone who doesn't play evoker wouldn't have that bug anymore? |
To clarify, I'm talking about the feature where you can hold a hotkey down and it'll continue to cast an ability until you release the key. This is different from the Evoker hold and release to cast different levels of a spell abilities. |
The beta version should hopefully resolve this error. Retail action buttons now use their own custom implementation |
There are multiple instances reported of actions not working in combat, typically after encountering a loading screen. These are all likely sourced from taint introduced via the new Edit Mode UI.
The text was updated successfully, but these errors were encountered: