Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on delete #72

Merged
merged 2 commits into from
Aug 27, 2017
Merged

Add on delete #72

merged 2 commits into from
Aug 27, 2017

Conversation

jwhitlock
Copy link
Member

@jwhitlock jwhitlock commented Aug 27, 2017 •
edited

  • Fix the docker build
  • Specify on_delete argument for all ForeignKey fields. This will be required in Django 2.0. The previous default was on_delete=CASCADE, and the initial migration needs this explicit value to continue working in Django 2.0.

@jwhitlock
Fix docker build
c3cd972 
CHANGELOG.rst is used to create the long description for the package.
@coveralls
Copy link

coveralls commented Aug 27, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 6f1c6eb on jwhitlock:add_on_delete into ed95729 on tulsawebdevs:master.

@coveralls
Copy link

coveralls commented Aug 27, 2017 •
edited

Coverage Status

Coverage decreased (-0.04%) to 99.959% when pulling 87a57f0 on jwhitlock:add_on_delete into ed95729 on tulsawebdevs:master.

2 similar comments
@coveralls
Copy link

coveralls commented Aug 27, 2017 •
edited

Coverage Status

Coverage decreased (-0.04%) to 99.959% when pulling 87a57f0 on jwhitlock:add_on_delete into ed95729 on tulsawebdevs:master.

@coveralls
Copy link

coveralls commented Aug 27, 2017 •
edited

Coverage Status

Coverage decreased (-0.04%) to 99.959% when pulling 87a57f0 on jwhitlock:add_on_delete into ed95729 on tulsawebdevs:master.

@jwhitlock
Add on_delete arguments to ForeignKeys
7ad4385 
This attribute will be required in Django 2.0. Update initial migration
to include the default of CASCADE, and then use better choices for
applicable models.
@coveralls
Copy link

coveralls commented Aug 27, 2017 •
edited

Coverage Status

Coverage decreased (-0.04%) to 99.959% when pulling ef8f63d on jwhitlock:add_on_delete into ed95729 on tulsawebdevs:master.

@coveralls
Copy link

coveralls commented Aug 27, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 7ad4385 on jwhitlock:add_on_delete into ed95729 on tulsawebdevs:master.

@jwhitlock jwhitlock merged commit f104c09 into tulsawebdevs:master Aug 27, 2017
@jwhitlock jwhitlock deleted the add_on_delete branch August 27, 2017 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwhitlock @coveralls