Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uma integration #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add uma integration #1

wants to merge 2 commits into from

Conversation

rafzi
Copy link
Member

@rafzi rafzi commented Feb 9, 2023

No description provided.

@PhilippvK
Copy link
Collaborator

Nice to see another usage of this tvmc wrapper.

I guess the Patch file for the tvmc/compiler.py is outdated. Have you applied it manually would be able to provide a new version of tvmc_diff.patch which works on the latest TVM version?

Copy link

@MichaelJKlaiber MichaelJKlaiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are yu going to create a PR into the TVM main?

@rafzi
Copy link
Member Author

rafzi commented Feb 10, 2023

@PhilippvK I didn't apply it from scratch but just merged, so the patch might be outdated. Ideally we could upstream the required TVMC changes soon, so that we can use the new upstream as basis for the new patch.

@MichaelJKlaiber Yes, that would be the goal. I'll wait for some more feedback in the discussion thread.

REF: https://discuss.tvm.apache.org/t/tvmc-uma-integration/14309

@PhilippvK
Copy link
Collaborator

I added a fixed patch file to the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants