Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not closed on my own sequence #16

Closed
liu-zg15 opened this issue Feb 4, 2019 · 4 comments
Closed

Not closed on my own sequence #16

liu-zg15 opened this issue Feb 4, 2019 · 4 comments

Comments

@liu-zg15
Copy link

liu-zg15 commented Feb 4, 2019

Hi, Thank you for this impressive work. I tried to use this on my own sequence. But I found it cannot be closed after a full loop. I don't whats happening. Could anyone help me?
I run
./bin/run_dso_tum_mono preset=0 setting_enableLoopClosing=true setting_pointSelection=1 files=/media/gone/Elements/TO_DSO/calibratedRADIO/images/ vignette=/home/gone/calib/radio/vignette.png calib=/home/gone/calib/radio/camera.txt gamma=/home/gone/calib/radio/pcalib.txt
in command.
No error happens but the result is just like below:
loop1
loop2
The command window just show this:
loop3
Is there anything I missed?

@gaoxiang12
Copy link
Collaborator

Hi @liu-zg15 The parameters about loop closing in LDSO in set to be a quite strict value to prevent false loops in our dataset, so many possible loops will be rejected during loop closure detection. You can adjust those parameters if the correct loop is not detected in your data. Taking a quick look of frontend/LoopClosing would be helpful.

@liu-zg15
Copy link
Author

Hi @gaoxiang12 . I really appreciate your reply.
I think you are right. The parameters about loop closing in LDSO are set to be very strict.
Changing some parameters in LoopClosing.cpp is the easiest way.(It works in my sequence) But be careful!. False loop will cause failure of whole procedure. I suggest to calibrate your camera more careful.

@amiltonwong
Copy link

Hi, @liu-zg15 and @gaoxiang12,

Which code should I modify for adapting my sequence (images located in a directory) as input source? Any hints for the modification?

THX!

@NikolausDemmel
Copy link
Contributor

@amiltonwong, I'm not sure this is related to this issue?

If your sequence is in one of the supported formats, just point to it with command line arguments. Or else implement your custom DatasetReader. Check the different executables in examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants