Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-callback-rul /action/link?description param does not seem to support HTML #80

Closed
joshgoebel opened this issue Dec 23, 2014 · 10 comments
Closed

Comments

@joshgoebel
Copy link

Example:

tumblr://x-callback-url/link?title=Your%20old%20laptop%27s%20battery%20will%20light%20homes%20in%20developing%20countries&url=http%3A%2F%2Fwww.engadget.com%2F2014%2F12%2F09%2Fibm-urjar-battery%2F&description=%21%28http%3A%2F%2Fo.aolcdn.com%2Fhss%2Fstorage%2Fmidas%2F4bdd5bcbafad648d96057bd6ba4968aa%2F201215004%2Flight-bulb-street-vendor-india-daniel-berehulak-getty.jpg%29%0A%0A%3Cimg%20src%3D%27http%3A%2F%2Fo.aolcdn.com%2Fhss%2Fstorage%2Fmidas%2F4bdd5bcbafad648d96057bd6ba4968aa%2F201215004%2Flight-bulb-street-vendor-india-daniel-berehulak-getty.jpg%27%3E%0A%0A%3E%20Don%27t%20be%20too%20quick%20to%20toss%20out%20the%20battery%20from%20that%20ancient%20laptop%20--%20it%20might%20just%20be%20the%20key%20to%20powering%20homes%20in%20developing%20countries%2C%20and%20helping%20the%20environment%20in%20the%20process.%20IBM%20researchers%20have%20revealed%20UrJar%2C%20a%20device%20that%20turns%20old%20lithium-ion%20battery%20packs%20into%20rechargeable%20energy%20sources%20for%20low-power%20devices%20like%20LED%20light%20bulbs%2C%20fans%20and%20cellphones.%0A%0AWhat%20a%20great%20idea.%20Places%20that%20accept%20batteries%20for%20recycling%20or%20proper%20disposal%20need%20to%20get%20clued%20into%20this.%0A%0A%20

The description field will be completely empty when Tumblr launches.

@joshgoebel joshgoebel changed the title /action/link?description does not seem to support HTML x-callback-rul /action/link?description param does not seem to support HTML Dec 23, 2014
@irace
Copy link
Contributor

irace commented Dec 23, 2014

This works just fine for me 😕

@joshgoebel
Copy link
Author

Does it perhaps matter that my default compost method is markdown?

@joshgoebel
Copy link
Author

How are you testing? I supposed it could be some weird editorial bug. I just pasted the RAW url into a one step workflow now and still seeing the exact same issue.

http://www.editorial-workflows.com/workflow/5891151760457728/QXII1J0jECI

Does this help at all?

@joshgoebel
Copy link
Author

I guess honestly that isn't the full url. editorial is still adding success and cancel callback urls to it, etc. but I wouldn't know how to get you a better example. I assume you could test it from Editorial and with your enhanced visibility to debug info find out quickly which side of the line the fault is on?

@irace
Copy link
Contributor

irace commented Dec 23, 2014

I've never used Editorial. I just pasted the URL into Safari and it worked as expected.

@joshgoebel
Copy link
Author

I see that. So the problem is either Editorial or Tubmlr getting choked on the extra xcallbacks parame that are being added that I don't have visibility to. Any way you could check that?

I'm not sure how to get a better URL myself.

@joshgoebel
Copy link
Author

Ok. Trick it to http then edit:

tumblr://x-callback-url/link?x-success=editorial%3A%2F%2Fworkflow-callback&x-cancel=editorial%3A%2F%2F&x-error=editorial%3A%2F%2Fworkflow-callback-error&x-source=Editorial&title=Your%20old%20laptop%27s%20battery%20will%20light%20homes%20in%20developing%20countries&url=http%3A%2F%2Fwww.engadget.com%2F2014%2F12%2F09%2Fibm-urjar-battery%2F

Broken from safari and editorial.

@joshgoebel
Copy link
Author

And the descriotion isnt even there. Wtf.

@irace
Copy link
Contributor

irace commented Dec 23, 2014

So it's an Editorial bug, it seems?

@joshgoebel
Copy link
Author

Seems so. If there is a = in the body (it even appears encoded correctly) then when Editorial does whatever it does to add its own xcallback params it discards the description param completely. Like its reparsing the whole url and then rejecting params for some reason.

@irace irace closed this as completed Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants