Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional parameters to XExtensionItemSourceApplication #17

Closed
irace opened this issue Apr 20, 2015 · 6 comments
Closed

Add additional parameters to XExtensionItemSourceApplication #17

irace opened this issue Apr 20, 2015 · 6 comments

Comments

@irace
Copy link
Contributor

irace commented Apr 20, 2015

Talk with @chrismaddern to make sure we’re on the same page with regards to which parameters apps should use to attribute themselves.

Here’s what we have so far: https://github.com/tumblr/XExtensionItem/blob/master/XExtensionItem/XExtensionItemSourceApplication.h

@irace
Copy link
Contributor Author

irace commented Apr 23, 2015

It looks as though the Button Deep Link Interoperability RFC only includes the following:

  • Store ID
  • App name
  • Display title

The first two are already included in XExtensionItemSourceApplication and display title doesn’t really make sense in the context of share extensions, so maybe we don’t have too much to discuss after all?

@irace irace changed the title Discuss attribution with Chris Maddern Add additional parameters to XExtensionItemSourceApplication Apr 28, 2015
@irace
Copy link
Contributor Author

irace commented Apr 28, 2015

After some internal discussion it seems like it’s worth adding the following optional properties as well:

  • Google Play ID
  • Web URL
  • iOS app URL
  • Android app URL

One could envision a scenario in which an app, e.g. Instapaper, shares into a service like Tumblr and we want to be able to give users who view the post the option to either install the app if they don't already have it, or deep-link in if they do.

@mbbischoff
Copy link
Contributor

Can’t the iOS App URL be derived from the app ID?

@irace
Copy link
Contributor Author

irace commented Apr 28, 2015

Can’t the iOS App URL be derived from the app ID?

This would be an app URL like instapaper://x-callback-url?article=12345

@mbbischoff
Copy link
Contributor

Ah, okay. Got it.

@AriX
Copy link
Contributor

AriX commented Apr 28, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants