Don’t pass extension items to system activities that can’t consume them #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3b00421.
|
I’ve ticketed the fact that I have no idea how to test the system Weibo activities: #39 |
Set your simulator’s region and language to China / Chinese. |
Thanks – I’m still going to leave this as a separate ticket until I have some chance to play with it. It’s a bit more involved since it involves creating two separate Weibo accounts – Sina and Tencent – the latter of which may require a Chinese telephone number? |
|
This should be ready to go. |
| @@ -4,6 +4,14 @@ | |||
| #import "CustomParameters.h" | |||
| #import "XExtensionItem.h" | |||
|
|
|||
| #define XCTAssertEqualExtensionItems(item1, item2) \ | |||
There was a problem hiding this comment.
Might be odd to use a prefix that’s not ours because theoretically Apple could add this same function.
irace
added a commit
that referenced
this pull request
May 6, 2015
…to-certain-system-activities Don’t pass extension items to system activities that can’t consume them
irace
deleted the
feature/dont-pass-extension-items-to-certain-system-activities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😡😡😡😡😡😡😡😡😡😡😡
Thanks to @prendio2 for catching this one. While some system activities do know how to consume
NSExtensionIteminput, others like Mail and Messages do not. Passing anNSExtensionItemto these doesn’t result in any data making its way through.Unfortunately I don’t know a better way to handle this other than to deduce (via trial and error) which activities can support extension item input, and pass the
placeholderobject to the ones that can’t.This PR to add more
UIActivityItemSourcehooks makes these changes a lot easier to swallow, in my opinion, even though this still sucks. I definitely need to radar this.CC: @mattbischoff @AriX